Skip to content

Single source of truth #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Single source of truth #4249

wants to merge 4 commits into from

Conversation

connorjward
Copy link
Contributor

This is an idea I've had to ensure single-source-of-truth across the repo. The basic idea is:

  • The supported PETSc and Python versions are set in a new config.ini file.
  • Running the new script check-config will read in files and make sure that things match, raising an exception if not.
  • This script is then run as part of CI.

I feel like this is a necessary change because with the recent install changes one needs to be careful to change version numbers in all the right places. For example it would have prevented #4230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant