-
Notifications
You must be signed in to change notification settings - Fork 167
Do not use Makefile for firedrake-check #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested refactoring how the tests to run are specified so it'd be easier to add other parallel tests with nprocs!=3 in the future. What do you think?
@JHopeCollins I have followed your suggestions though the code doesn't exactly match your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy with this, thanks @connorjward!
This is failing because the non-forking mpiexec problem is alive and kicking! I have a fix in this instance but it's interesting that this works fine on my machine. |
This should avoid CI failures due to forking mpiexec after importing Firedrake.
2329330
to
9ec8176
Compare
Merging as this was previously approved and passes CI in the relevant places. |
This is approved an can be merged once a new release of mpi-pytest is made. (now done)