Skip to content

Fix AUTHORS.rst #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Fix AUTHORS.rst #4420

merged 2 commits into from
Jul 9, 2025

Conversation

connorjward
Copy link
Contributor

I shouldn't have forced #4417 through. See https://github.com/firedrakeproject/firedrake/actions/runs/16000431717/job/45133718667?pr=4419 for the failure we are now getting.

@connorjward connorjward requested a review from JHopeCollins July 2, 2025 12:57
@JHopeCollins
Copy link
Member

Ah, yeah of course, apologies.

The fix looks fine, but can you add a line to the untracked files step in the ci to print out the git diff if any files are unexpectedly modified?

@connorjward
Copy link
Contributor Author

Ah, yeah of course, apologies.

The fix looks fine, but can you add a line to the untracked files step in the ci to print out the git diff if any files are unexpectedly modified?

Good idea. Done.

Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the slepc fix merging so the CI will run.

@dham dham merged commit af2f5ba into release Jul 9, 2025
5 of 7 checks passed
@dham dham deleted the connorjward/fix-authors branch July 9, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants