Fix multigrid caches #4511
Open
Fix multigrid caches #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/mg-cache
branch
from
2e52374 to
f8447ce
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg-cache
branch
from
a4f0728 to
22c1a81
Compare
|
Please fix |
ksagiyam
reviewed
Sep 5, 2025
Comment on lines
+82
to
+84
| w1 = StandaloneInterpolationMatrix.work_function(V1) | ||
| w2 = StandaloneInterpolationMatrix.work_function(V2) | ||
| assert w1 is w2 |
There was a problem hiding this comment.
This make me wonder if we should implement restore() method to keep track of if the work_function is in_use or not, but it's not the scope of this PR.
There was a problem hiding this comment.
Should we also look at FunctionSpace.get_work_function()?
There was a problem hiding this comment.
That's probably better as they already have restore method.
ksagiyam
reviewed
Sep 5, 2025
ksagiyam
reviewed
Sep 5, 2025
Co-authored-by: ksagiyam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description