Skip to content

refactor interpolation #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 103 commits into
base: main
Choose a base branch
from
Draft

refactor interpolation #4595

wants to merge 103 commits into from

Conversation

leo-collins
Copy link
Contributor

@leo-collins leo-collins commented Sep 26, 2025 •
edited
Loading

An attempt to clean up interpolation code. Currently includes #4582. So far:

  • Removed interp_data dictionary in favour of the InterpolateOptions dataclass. We get type hinting, better IDE support, single source of truth for these options.
  • Interpolator becomes an internal object. I removed the __new__ method and dispatch instead with a _get_interpolator function.
  • We can now matfree adjoint interpolate cross-mesh and VomOntoVom. The renumbering malarkey is completely removed.
  • Can now assemble cross-mesh interpolation operators, both forward and adjoint.

@pbrubeck
Matfree adjoint interpolation
e956adb
@pbrubeck
Update interpolation.py
29a410d
@pbrubeck
Fixup, cleanup
a33cfb3
@pbrubeck
Reverse indices for dual_arg
d51db25
@pbrubeck
gem cofunction
afe0256
@pbrubeck
More fixups
7aa048e
@pbrubeck
More fixup
9826f0d
@pbrubeck
Fixup
4ce9f8e
@pbrubeck
cleanup
ae80c0f
@pbrubeck
Fix Real adjoint
7fa72d6
@pbrubeck
Fixup
3f5ca71
@pbrubeck
Fix multiindices
42f848c
@pbrubeck
Remove interpolate(Function(DG0), CG2) from test
08dba92
@pbrubeck
Do not sum_factorise
d1a0710
@pbrubeck
Fix complex conjugate
9329d1a
@pbrubeck
Suggestions from review
44a98ed
@pbrubeck
Reusable Interpolator
120a2a3
@pbrubeck
Allow interpolate(..., BaseForm)
af77aac
@pbrubeck
Merge branch 'main' into pbrubeck/interp-adjoint
820038c
@pbrubeck
Update firedrake/assemble.py
ea5c07b
@pbrubeck
Explicitly assemble the interpolate adjoint matrix
62fa31e
@pbrubeck
Fix up
ef0b10c
@pbrubeck
Move renumbering logic to Interpolator
34ea5f3
@pbrubeck
Fix up
f82b140
@pbrubeck
Enhacements for interpolation into VOM
be0f779
@pbrubeck
SameMeshInterpolator: support matfree/explcit adjoint on Submesh
6407f4e
@pbrubeck
Update tsfc/driver.py
449420f
@pbrubeck
Test submesh in parallel
f614764
@pbrubeck
VOM onto other VOM still needs renumbering
ea997ea
@pbrubeck
Clarify insane interface
eee77d6
@leo-collins
move FunctionSpace check into Interpolate
c1851b0 
fix
@leo-collins
lint
7313d41
@leo-collins
test -> trial
bcb6b31 
test -> trial

fix hypre-ads
@leo-collins
tidy function.interpolate
613c8ed
@leo-collins
tidy cofunction.interpolate
c453baa 
cofunction docstring
@leo-collins
tidy type hints in function.py
55662be
@leo-collins
remove UFL branch
f40e3e7
@leo-collins
lint
7793456
@leo-collins
fix typing
7a9e85c 
fix
@leo-collins
Merge branch 'leo/simplify-interpolate' into leo/refactor_interpolate
2de1256
@leo-collins
tidy
6aed689 
typing
@leo-collins
review suggestions
a336ea4
@leo-collins
Squashed commit of the following:
792f703 
commit 3aeb517
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 17:17:44 2025 +0100

    Test the MixedInterpolator 0-form across different meshes

commit fee366a
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 16:56:56 2025 +0100

    Implement missing functionality in CrossMeshInterpolator

commit e400fc9
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 15:16:39 2025 +0100

    cleanup

commit 997e638
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 12:57:59 2025 +0100

    cleanup

commit f1080ea
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 09:11:07 2025 +0100

    Interpolate: support fieldsplit

commit 76ec367
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 07:26:07 2025 +0100

    Fixup

commit 3bd935e
Author: Pablo Brubeck <[email protected]>
Date:   Wed Oct 1 00:23:21 2025 +0100

    MixedInterpolator
@leo-collins
tidy
fa25a2b 
fix options

fixes
@leo-collins
remove V argument
c278709 
fixes
@leo-collins
assemble cross-mesh interpolation matrix; add test
12379cc
@leo-collins
assemble adjoint cross-mesh interpolation matrix
fbc0e86 
First stage of removing the renumbered interpolate
@leo-collins
changes
66f1658
@leo-collins
remove repeated checks
ae4454c
@leo-collins
progress on adjoint cross-mesh / vom-to-vom
40fd76f
@leo-collins
tidy
a561312
@leo-collins
tidy
41a304a
@leo-collins
fixes
138943b
@leo-collins
fixes
26fa610
@leo-collins
fixed zero-form cross mesh
b6d3d59
@leo-collins
remove vomontovomwrapper
1d13779
@leo-collins
fixes
c26707c
@leo-collins
tidy import
7b4717a
@leo-collins leo-collins force-pushed the leo/refactor_interpolate branch from 2bd7a49 to 7b4717a Compare October 11, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbrubeck pbrubeck pbrubeck left review comments

@connorjward connorjward connorjward left review comments

@dham dham dham requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leo-collins @connorjward @pbrubeck @dham