-
Notifications
You must be signed in to change notification settings - Fork 167
Firedrake meeting 2023 11 15
Date and time 2023-11-15 1600 GMT (1600 UTC)
- Pick Chair and Minuter (JB to pick minuter - RNH picked)
- ALL: (ongoing) triage the open issues and confirm if they are indeed still open (and perhaps provide labels)
- JB: Move pyop3 and FInAT to firedrakeproject
- ALL: do things with SV's branches
- see below
- DH: Email to Andreas to have 2 (+ others!!!) loopy PRs merged TODO: FIND OUT WHICH PRS THESE ARE
- RK says Andreas thinks the ball is in someone else's court
- DH: Get Firedrake a docker open source account (link here)
- DH: Talk to GregVernon about PR#2116.
- DH: Revisit PR#2484.
- DH: Order more Firedrake stickers
- ALL/ANY: Drop libsupermesh (minutes)?
- UZ: Review, check and merge upstream NGSolve changes required for UFL update. DONE!
- NB: Look for changes needed to manual to account for dual spaces
Present: JB, KS, CW, RK, NB, UZ, PB, FA, RNH
Apologies:
Now this has been merged, Firedrake test suite now runs faster! Some cool new things coming soon (the minuter missed exactly what these were)
Done https://github.com/firedrakeproject/firedrake/pull/3166
Master is failing! UZ needs to fix his NGSPetsc merge, which wasn't testing against the correct branches. Seems to be an easy fix, using a method which is no a property. Connor fix it!
Not an underhanded power grab whilst David is away! I just want some input on what everyone thinks of the current meeting format and PR merging process.
- Code review is technical and doesn't always involve everybody
- Suggestion: Ask someone (Jack, Koki, Connor, Nacime) to review before meeting (this is what Jack and Connor did before this meeting)
- Like the idea of adding more space for discussion
JB says can just add an Irksome page to the Firedrake manual. CW suggests this can be under a 'firedrake and friends' section which would link to the actual Irksome documentation in the Irksome repo (could also icepack etc). Could also be a demo or notebook!
- PB: TSFC #301. Changes requested
- Failing tests after merge of Matt Scroggs UFL stuff
- PB: FD docs #3221. Dependent on TSFC #301
- PB: MG bugfix #3231. Changes Requested
1600 GMT (1600 UTC) 2023-11-22