Skip to content

Windows support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 11, 2025
Merged

Windows support #24

merged 13 commits into from
Jun 11, 2025

Conversation

connorjward
Copy link
Collaborator

Fixes #22 (assuming that it works)

Copy link
Contributor

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been working through this myself at it seems the same speed/time. I have a few edit suggestions based on things I found that worked on the windows PC I have available.

@connorjward connorjward marked this pull request as ready for review June 10, 2025 18:58
@connorjward
Copy link
Collaborator Author

@mkolopanis does this work for you locally now?

@mkolopanis
Copy link
Contributor

It does indeed. Both forking and non-forking tests pass locally for me.

@connorjward
Copy link
Collaborator Author

Great. I will merge this and make a release soon. Thanks for your help.

@connorjward connorjward merged commit b1ba60e into main Jun 11, 2025
30 checks passed
@connorjward connorjward deleted the connorjward/windows branch June 11, 2025 08:11
@mkolopanis
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Against Other OSes
2 participants