Report: longer content — arch summary, findings table, full minor blocks - #30
Merged
Conversation
Give users more to fix without inventing findings or breaking the deterministic score. Everything new is OUTSIDE the share card. - "What Even Is This": a savage-but-TRUE architecture summary — new arch_summary / arch_transition fields (schema + template + renderer). Every architectural claim must point at a real file (package.json deps, dir layout, config); backtick refs render as <code> (escape-then-wrap, no un-escaping). New Voice-register rule enforces the fact discipline. - "Findings by Priority": an overview table of every finding, worst-first, derived from dimensions[].findings[] (no new required field). New tpl-findings-block / tpl-finding-row + FINDINGS_BLOCK token. - Minor tier upgraded to FULL fix blocks in the markdown report shape (Evidence / Root cause / The fix / Verify), matching what the HTML renderer already did for Medium/Low. Renderer now accepts a Low tag. - example-report.md + fixture updated; stale hosted-URL and link-CTA in the example corrected to the S3 report.first-tree.ai form + no-link teaser. render-report.test.mjs: 17/17 pass. Rendered fixture verified in a real browser — all 5 sections render, card untouched, no horizontal overflow, arch code chips escaped safely. Refs #29. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #29.
Makes the report longer so users have more to fix — without inventing findings or breaking the deterministic score. All new content is OUTSIDE the share card (the card is byte-untouched).
What's new (all outside the card)
arch_summary/arch_transitionfields. Fact discipline (hard rule): every architectural claim must point at a real file (package.jsondeps, dir layout, config) — backtick refs render as<code>. New Voice-register rule enforces it. Then a one-line transition into the professional fix zone.dimensions[].findings[](no new required field).Lowtag.Contract synced (3 points)
skill
SKILL.mdschema +render-report.mjs+report-template.html, mirrored on the website side (scanSample.ts+api/reportsvalidateReport +ScanReport.astro) in the paired website PR.Verification
render-report.test.mjs: 17/17 pass.<code>chips escaped safely, card untouched, no horizontal overflow.example-report.mdupdated to the new shape; corrected a stale hosted-URL + link-CTA in the example to the S3report.first-tree.ai/<key>.htmlform and the no-link teaser.🤖 Generated with Claude Code