Add noOp Logic and unit test#654
Open
diego-santinelli-hrm wants to merge 1 commit intofiskaltrust:mainfrom
Open
Add noOp Logic and unit test#654diego-santinelli-hrm wants to merge 1 commit intofiskaltrust:mainfrom
diego-santinelli-hrm wants to merge 1 commit intofiskaltrust:mainfrom
Conversation
github-actions
bot
added
market-it
accodev
reviewed
Apr 7, 2026
scu-it/src/fiskaltrust.Middleware.SCU.IT.CustomRTServer/CustomRTServerSCU.cs
Show resolved
Hide resolved
accodev
previously approved these changes
Apr 7, 2026
StefanKert
reviewed
Apr 7, 2026
| } | ||
|
|
||
| if (request.ReceiptRequest.IsDailyClosing()) | ||
| if (request.ReceiptRequest.IsDailyClosing() || request.ReceiptRequest.IsMonthlyClosing() || request.ReceiptRequest.IsYearlyClosing()) |
Member
There was a problem hiding this comment.
How are we handling this in the Epson Printer? I am not sure if we should expect MonthlyClosing & YearlyClosing to also do a DailyClosing. Usually these operations are cauled in sequence:
- December
- Daily Closing (31 of dec)
- Monthly Closing (closing december)
- Yearly Closing (closing the year)
So we would do three daily closings in this scenario
Author
There was a problem hiding this comment.
In the Epson SCU we handle it the same way — all three (Daily, Monthly, Yearly)
call PerformDailyCosing() as separate if blocks (see EpsonRTPrinterSCU.cs lines
96-109). So yes, in the Dec 31 scenario we'd get three daily closings, which is
the expected behavior since each closing triggers a Z report on the fiscal device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581 and #584 in
CustomRTServerSCU: both issues had the same root cause: unhandled receipt cases were throwing an exception instead of returning gracefully.PerformDailyCosingAsync, same asDailyClosingFixes #584 #581