fix: PO generator handles non-primitive RadioGroup value types gracef…#651
Open
sionans wants to merge 1 commit into
Open
fix: PO generator handles non-primitive RadioGroup value types gracef…#651sionans wants to merge 1 commit into
sionans wants to merge 1 commit into
Conversation
…ully PogRadioGroup.renderObjectValue() threw IllegalStateException when encountering RadioGroup values of complex types like SectorModel. Changes: - Add Number handling in renderObjectValue() - Add toString() fallback for unknown complex types instead of throwing - Fall back to String type parameter in acceptChildren() when the resolved value type is not Boolean, Enum, String, or Number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PogRadioGroup.renderObjectValue() threw IllegalStateException when encountering RadioGroup values of complex types like SectorModel. Changes: