Porting maxWeightMatching and maximalMatching #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function weightedBlossomEdmonds(debug, CHECK_OPTIMUM, CHECK_DELTA) { | ||
|
|
||
| // If assigned, DEBUG(str) is called with lots of debug messages. | ||
| var DEBUG = debug ? function(s){ console.log('DEBUG:', s); } : null; |
There was a problem hiding this comment.
Do we need to keep the debug option of the original implementation or can we just drop it?
new files
==
- src/algorithms/matching.js (coverage 96.21%)
- jsnx.maxWeightMatching
- jsnx.maximalMatching
- src/algorithms/__tests__/matching-test.js
modified files
==
- package.json
- corrected a typo in script/cover (nom -> npm)
- src/_internals/Set.js
- added an `update` method to the set class (like Python's set update)
`union` for sets rewritten to use this new method
- src/algorithms/index.js
- added exports for new matching algorithms
|
Thanks for that! I will have a closer look and answer your questions on the weekend. I just don't find the time during the week. |
|
Got time to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new files
modified files
updatemethod to the set class (like Python'sset()update),unionfor sets rewritten to use this new method