Skip to content

Fix last link value issue when result is empty #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RuiLiuRL wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix last link value issue when result is empty #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ module.exports = class Ext {

const maxPage = zeroIndex ? pageCount - 1 : pageCount
const meta = {}
const hasLast =
!Utils.isNil(totalCount) && totalCount !== 0
const hasNext =
!Utils.isNil(totalCount) && totalCount !== 0 && currentPage < maxPage
const hasPrevious =
Expand Down Expand Up @@ -253,7 +255,7 @@ module.exports = class Ext {
this.assignIfActive(
meta,
'last',
getUri(!zeroIndex ? pageCount : pageCount - 1)
hasLast ? getUri(!zeroIndex ? pageCount : pageCount - 1) : null
)

const newSource = {
Expand Down
17 changes: 17 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,6 +2180,23 @@ describe('Empty result set', () => {
expect(response.statusCode).to.be.greaterThan(199)
expect(response.statusCode).to.be.lessThan(300)
})

it('Last, next, and previous links should be null', async () => {
const server = register()
await server.register(require(pluginName))

const request = {
method: 'GET',
url: '/empty'
}

const res = await server.inject(request)

const response = res.request.response.source
expect(response.meta.last).to.be.null()
expect(response.meta.next).to.be.null()
expect(response.meta.previous).to.be.null()
})
})

describe('Exception', () => {
Expand Down