Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented May 21, 2025

Fixes #4202

Changes proposed in this pull request:

  • Create new reusable hero component to streamline the implementation of each variation

Reviewers should focus on:

  • Tried to keep the core abstract implementation as lightweight as possible
  • Perhaps some methods or the new class itself could be named better
  • Does this change need to be documented?
  • Are there any other Hero implementations i've missed?

Screenshot
DOM / UI should stay the same

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review May 22, 2025 09:12
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner May 22, 2025 09:12
@imorland imorland changed the title feat: create reusable Hero component [2.x] feat: create reusable Hero component Nov 2, 2025
@DavideIadeluca DavideIadeluca changed the title [2.x] feat: create reusable Hero component feat(core, tags): create reusable Hero component Nov 8, 2025
@DavideIadeluca DavideIadeluca changed the title feat(core, tags): create reusable Hero component feat: create reusable Hero component Nov 8, 2025
@DavideIadeluca
Copy link
Contributor Author

FYI @imorland I just made a minor change I've had in mind. This PR is now good to go from my side

@imorland imorland added this to the 2.0.0-beta.4 milestone Nov 9, 2025
@imorland imorland modified the milestones: 2.0.0-beta.4, 2.0.0-beta.5 Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Reusable Hero Component

2 participants