Fix exceptions structure (#21)

* fix exceptions structure.

Author: flask-pro

src/flask_first/__init__.py

@@ -26,11 +26,10 @@
 from .exceptions import FirstRequestPathArgsValidation
 from .exceptions import FirstResponseJSONValidation
 from .exceptions import FirstValidation
-from .exceptions import register_errors
 from .schema.tools import convert_schemas
 from .schema.tools import resolving_refs
 
-__version__ = '0.12.1'
+__version__ = '0.13.0'
 
 
 class First:
@@ -291,7 +290,6 @@ def add_response_validating(response: Response) -> Response:
     def init_app(self, app: Flask) -> None:
         self.app = app
         self.app.config.setdefault('FIRST_RESPONSE_VALIDATION', False)
-        register_errors(self.app)
         self.app.extensions['first'] = self
 
         if self.swagger_ui_path:

src/flask_first/exceptions.py

@@ -1,13 +1,4 @@
 """The module contains the exceptions used in the Flask-First extension."""
-from flask import current_app
-from flask import Flask
-from flask import jsonify
-from flask import make_response
-from flask import Response
-
-
-def _bad_request(description: str) -> Response:
-    return make_response(jsonify(code=400, name='Bad Request', description=description), 400)
 
 
 class FirstException(Exception):
@@ -40,34 +31,3 @@ class FirstRequestJSONValidation(FirstValidation):
 
 class FirstResponseJSONValidation(FirstValidation):
     """Exception for response validation error."""
-
-
-def register_errors(app: Flask) -> None:
-    """Registering handlers for common errors."""
-
-    @app.errorhandler(FirstRequestPathArgsValidation)
-    def path_args_validation_exception(exc) -> Response:
-        current_app.logger.debug(exc)
-        return _bad_request(str(exc))
-
-    @app.errorhandler(FirstRequestArgsValidation)
-    def args_validation_exception(exc) -> Response:
-        current_app.logger.debug(exc)
-        return _bad_request(str(exc))
-
-    @app.errorhandler(FirstRequestCookieValidation)
-    def cookie_validation_exception(exc) -> Response:
-        current_app.logger.debug(exc)
-        return _bad_request(str(exc))
-
-    @app.errorhandler(FirstRequestJSONValidation)
-    def request_validation_exception(exc) -> Response:
-        current_app.logger.debug(exc)
-        return _bad_request(str(exc))
-
-    @app.errorhandler(FirstResponseJSONValidation)
-    def response_validation_exception(exc) -> Response:
-        current_app.logger.error(exc)
-        return make_response(
-            jsonify(code=500, name='Internal Server Error', description=str(exc)), 500
-        )

tests/test_args.py

@@ -1,8 +1,10 @@
 from pathlib import Path
 
+import pytest
 from flask import Flask
 from flask import request
 from flask_first import First
+from flask_first.exceptions import FirstRequestArgsValidation
 
 from .conftest import BASEDIR
 
@@ -27,9 +29,9 @@ def create_app():
 
     app = create_app()
 
-    with app.test_client() as test_client:
-        r = test_client.get(
+    with pytest.raises(FirstRequestArgsValidation) as e:
+        app.test_client().get(
             '/parameters_endpoint',
             query_string={'non_exist_arg': 'NON_EXIST_ARGS'},
         )
-        assert r.status_code == 400
+    assert str(FirstRequestArgsValidation) in str(e.type)

tests/test_flask_first.py

@@ -7,6 +7,7 @@
 from flask import request
 from flask import Response
 from flask_first import First
+from flask_first.exceptions import FirstRequestPathArgsValidation
 
 from .conftest import BASEDIR
 
@@ -85,9 +86,10 @@ def get_item(uuid: str) -> Response:
 
     fx_app.extensions['first'].add_view_func(get_item)
 
-    r_get = fx_client.get(f'/items/{path_param}')
-    assert r_get.status_code == 400
-    assert "{'uuid': ['Not a valid UUID.']}" in r_get.json['description']
+    with pytest.raises(FirstRequestPathArgsValidation) as e:
+        fx_client.get(f'/items/{path_param}')
+    assert str(FirstRequestPathArgsValidation) in str(e.type)
+    assert "{'uuid': ['Not a valid UUID.']}" in e.value.args[0]
 
 
 def test_specification__all_type_url_parameters(fx_app, fx_client):