GlobalShortcuts: Add a request to configure shortcuts #1661
+153
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sodivad
force-pushed
the
configureshortcuts
branch
from
145c11a to
d32ae8f
Compare
jadahl
reviewed
Mar 12, 2025
Sodivad
force-pushed
the
configureshortcuts
branch
4 times, most recently
from
8a6f3b1 to
3fa1731
Compare
swick
reviewed
Mar 13, 2025
swick
reviewed
Mar 13, 2025
swick
reviewed
Mar 13, 2025
|
Seems like a useful addition. Just a few details to iron out, but I'd also like to have an implementation before we merge this. |
As mentioned on Matrix this allows an application to steer their users to the place where they can configure global shortcutcs of the application. Signed-off-by: David Redondo <[email protected]>
Sodivad
force-pushed
the
configureshortcuts
branch
from
3fa1731 to
0b255f4
Compare
implementation of what? I did a backend impl, see the description |
|
I missed that this already has a backend impl. |
swick
approved these changes
Mar 21, 2025
swick
reviewed
Mar 21, 2025
| g_variant_builder_end (&options_builder), | ||
| NULL, | ||
| shortcuts_configure_cb, | ||
| invocation); |
There was a problem hiding this comment.
You have to keep the invocation alive, so g_object_ref here, and assign to an autoptr (or otherwise unref at the end) in shortcuts_configure_cb.
swick
requested changes
Mar 21, 2025
| { | ||
| g_dbus_error_strip_remote_error (error); | ||
| g_warning ("Failed to configure shortcuts: %s", error->message); | ||
| g_dbus_method_invocation_return_gerror(invocation, error); |
There was a problem hiding this comment.
Suggested change
| g_dbus_method_invocation_return_gerror(invocation, error); | |
| g_dbus_method_invocation_return_gerror (invocation, error); |
| return; | ||
| } | ||
|
|
||
| xdp_dbus_global_shortcuts_complete_configure_shortcuts(XDP_DBUS_GLOBAL_SHORTCUTS(global_shortcuts), invocation); |
There was a problem hiding this comment.
Suggested change
| xdp_dbus_global_shortcuts_complete_configure_shortcuts(XDP_DBUS_GLOBAL_SHORTCUTS(global_shortcuts), invocation); | |
| xdp_dbus_global_shortcuts_complete_configure_shortcuts (XDP_DBUS_GLOBAL_SHORTCUTS (global_shortcuts), invocation); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on Matrix this allows an application to steer their users to the place where they can configure global shortcutcs of the application.
kde portal impl: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/a8b7532e33d98bdaf034a92c624bc63adaceec5c
client side impl in ashpd: Sodivad/ashpd@21be0f5