-
-
Couldn't load subscription status.
- Fork 890
refactor: migrate tile rendering from widgets to CustomPainter
#1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaced `TileBuilder` with `TileOverlayPainter` Updated examples
|
Hi. Any insights on this? That CPU usage is still very high. This was cutting it down by half or more. I don't know if there are any other plans to reduce it. |
|
I couldn't find an improvement in performance as big as was suggested on a non-web platform, but I'll go back and see if I can do some more detailed testing (as it wasn't massively detailed before). There wasn't an immediate plan to merge this, but it's definitely something we can consider in the short-to-mid term. |
|
It is the WEB platform that has slow performance. |
|
We're still looking towards potentially merging this, but we will need to just verify that loosing the ability to render widgets over tiles is acceptable. I'm not 100% sure it is without a good workaround. |
|
Hi. I'm not entirely sure how that would be structured, but if tileBuilder could be replaced or extended to expose visible tiles, their positions, XYZ-key and sizes, it would allow developers to overlay widgets properly. With that you could still use this CustomPainter if desired without loosing the ability to render widgets over tiles. |
|
Hey @ReinisSprogis :) We are actually planning to move ahead in some form with a new primarily canvas-based tile layer as we move towards better support & integration for other tile types. Of course this issue if overlaying widgets onto the canvas is still unresolved. So what you are talking about is a very good point to consider in any new implementation in that we might require lower level and more state-integrated control of widget tiles. I guess it would be the same for a canvas layer as well. I'm not sure yet how everything will fit together, but we'll try to cover as many bases as possible ofc. The idea is that we create a base tile layer and a few implemented variants, but it becomes much more extensible for end users to implement a custom tile layer if required. |
|
See #2120. I'm going to close this PR as replaced by that - however, this is still a very useful resource that I will keep referring to to implement the new raster layer, so thanks @ReinisSprogis :) |
Superceeds #1853 & continues #1908 targeting
master.