Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kdbush worker #190

Merged
merged 3 commits into from
Aug 3, 2024
Merged

fix: kdbush worker #190

merged 3 commits into from
Aug 3, 2024

Conversation

flekschas
Copy link
Owner

This PR fixes the KDBush worker in the production build.

Description

What was changed in this pull request?

To avoid name clashes, the worker now depends on a named function declaration.

Why is it necessary?

Previously it was possible that due to bundling and code minimization, the class KDBush was renamed. Since the worker function didn't know about this, the KDBush worker ultimately failed.

Fixes #189

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

@flekschas flekschas added the bug Something isn't working label Aug 3, 2024
@flekschas flekschas merged commit e9ee076 into master Aug 3, 2024
2 checks passed
@flekschas flekschas deleted the flekschas/fix-kdbush-worker branch August 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDBush worker fails due to missing KDBush
1 participant