-
Notifications
You must be signed in to change notification settings - Fork 521
Rename flet.app()
to flet.run()
+ improve code and docs in some files
#5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Maybe i will rename |
flet.app()
to flet.run()
flet.app()
to flet.run()
+ improve code and docs in some files
@sourcery-ai summary |
@sourcery-ai review |
We are currently working hard on releasing "v1" which, actually, has |
Maybe we can add, but without deletion of deprecations in 0.x versions. Maybe we'll delete deprecations in 1.0? |
@sourcery-ai summary |
…abillity to not provide `delete_version`
…ove deprecation system
@FeodorFitsner Can you review my PR? I wants to help with easy for me things, how before) |
Well, thanks for your help. However, our goal is to avoid pushing any changes (except bug fixes) to 0.2x releases and focus on 0.70 (which is pre "v1"). I'd like to leave |
Some small fixes, polishing for 0.2x - YES, changing/adding/removing functionality - NO. |
Description
I made task to rename
flet.app()
toflet.run()
in issue #5238. Also i renamedapp_async()
torun_async()
. I did annotations for these methods, but i need help withhost
parameter inapp()
andapp_async()
. I don't know its type. Also i simplified some code inapp.py
. Maybe i will do some extra fixes in another files.Fixed that things from #5238:
SegmentedButton
:selected: List[str]
instead ofOptional[Set]
. Example:selected=["1", "4"]
instead ofselected={"1", "4"}
. TODO: support sets in flet V1ft.app(target=main)
should be changed toft.run(main)
orft.run(main=main)
Test Code
# Test code for the review of this PR
Type of change
Checklist
*i can do it. I suggest to add documentation for
flet.run()
andflet.run_async()
(i didn't find it), i can help with it.Screenshots
Additional details
Summary by Sourcery
Rename
flet.app()
andflet.app_async()
toflet.run()
andflet.run_async()
respectively, introducing improved type annotations and deprecation handling.New Features:
Bug Fixes:
Enhancements:
Chores: