Skip to content

fix: update SDK test for mainnet v2 addresses#9

Merged
MrTalecky merged 1 commit into
mainfrom
fix/sdk-mainnet-v2-test
Mar 26, 2026
Merged

fix: update SDK test for mainnet v2 addresses#9
MrTalecky merged 1 commit into
mainfrom
fix/sdk-mainnet-v2-test

Conversation

@MrTalecky

Copy link
Copy Markdown
Member

Summary

  • PR chore: add Base mainnet deployment addresses #8 added real mainnet v2 deployment addresses but didn't update the SDK test
  • Test deployments.test.ts still expected zero placeholder addresses for mainnet v2 (vault, factory)
  • Updated test to verify all mainnet v2 addresses are non-zero (matching Sepolia v2 pattern)
  • CI was failing: 823/824 passed, 1 failed — now 824/824 pass

Test plan

  • npx vitest run — all 824 tests pass
  • Verified test matches actual deploymentsBaseMainnetV2 data

🤖 Generated with Claude Code

PR #8 added mainnet deployment addresses but the test still expected
zero placeholders, causing CI failure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@MrTalecky MrTalecky merged commit dce9e2d into main Mar 26, 2026
2 checks passed
@MrTalecky MrTalecky deleted the fix/sdk-mainnet-v2-test branch March 26, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant