Skip to content

Conversation

@python273
Copy link

Using numpy for a few functions seems quite excessive, I replaced it python lists. Also some bugfixes

@doomwastaken doomwastaken self-requested a review November 24, 2022 11:53
@doomwastaken
Copy link
Contributor

I will take a look tomorrow, thank you.

Just want to clarify that this is mostly internal tool that is being used for our integration/e2e flipper tests at this moment.
Saw the issue as well, will fix that next week

@python273
Copy link
Author

I mainly use it for reuploading an app after compilation. qFlipper-cli doesn't have file transfer cmds

@doomwastaken
Copy link
Contributor

oh I see, that is one way to do it, I will talk to dev of qflipper, maybe it is easy to introduce to the cli version

@doomwastaken
Copy link
Contributor

as for qflipper, there will be no updates sadly

as for pull request, let me quickly go through code

Copy link
Contributor

@doomwastaken doomwastaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got only two real comments about it, rest will test after those changes

If you do believe that reverting coordinates is needed, then I will have to go through protobuf_py code and see how widely it is being used

@reactormonk
Copy link

Would be cool to merge these changes, as the old numpy dependency blocks installing this package on python 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants