fix: do not emit empty SSE event after comment when last id is sticky - #46
Open
ltsyk wants to merge 2 commits into
Open
fix: do not emit empty SSE event after comment when last id is sticky#46ltsyk wants to merge 2 commits into
ltsyk wants to merge 2 commits into
Conversation
fix SSEDecoder: sticky last_event_id alone must not dispatch (florimondmanca#35)
Author
|
Reformatted with black so the Azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After an event with an
id:field, a comment line (: ping) followed by a blank line incorrectly produced a phantom empty event._last_event_idis sticky per the SSE spec and must not, by itself, trigger a dispatch.Change
When handling a blank line, only consider
_event,_data, and_retryas reasons to dispatch — not the sticky last event id.Test plan
test_iter_sse_comment_after_id_does_not_emit_empty_event(issue Incorrect comment parsing when using ids #35 repro)Fixes #35