chg: [connection] prevent modifying type

flowintel · Oct 11, 2024 · 7545012 · 7545012
1 parent 0de657c
commit 7545012
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 10 deletions.
diff --git a/lib/cocktailparty/input.ex b/lib/cocktailparty/input.ex
@@ -198,8 +198,6 @@ defmodule Cocktailparty.Input do
       {:ok, connection} = Repo.update(changeset)
       ConnectionManager.start_connection(connection)
       {:ok, connection}
-      # same for its sources
-
     else
     Repo.update(changeset)
     end
@@ -234,6 +232,19 @@ defmodule Cocktailparty.Input do
     Connection.changeset(connection, attrs)
   end
 
+  @doc """
+  Returns an `%Ecto.Changeset{}` for tracking connection changes -- without the type
+
+  ## Examples
+
+      iex> change_edit_connection(connection)
+      %Ecto.Changeset{data: %Connection{}}
+
+  """
+  def change_edit_connection(%Connection{} = connection, attrs \\ %{}) do
+    Connection.edit_changeset(connection, attrs)
+  end
+
   @doc """
   Get the status of a redis connection
 

diff --git a/lib/cocktailparty/input/connection.ex b/lib/cocktailparty/input/connection.ex
@@ -27,6 +27,15 @@ defmodule Cocktailparty.Input.Connection do
     |> validate_config()
   end
 
+  @doc false
+  # we don't allow for changing a connection type once created
+  def edit_changeset(connection, attrs) do
+    connection
+    |> cast(attrs, [:name, :config, :enabled, :sink])
+    |> validate_required([:name, :config, :enabled, :sink])
+    |> unique_constraint(:name)
+  end
+
   defp validate_config(changeset) do
     case get_field(changeset, :type) do
       nil ->
@@ -41,7 +50,7 @@ defmodule Cocktailparty.Input.Connection do
   end
 
   @doc """
-  Kill processes related to a redis instance
+  Kill processes related to a connection
   TODO
 
   """
@@ -71,7 +80,7 @@ defmodule Cocktailparty.Input.Connection do
       nil ->
         # TODO
         Logger.error(
-          "It looks like the redis instances dynamic supervisor is dead, it's not looking good."
+          "It looks like the connection dynamic supervisor is dead, it's not looking good."
         )
 
         nil

diff --git a/lib/cocktailparty_web/controllers/admin/connection_controller.ex b/lib/cocktailparty_web/controllers/admin/connection_controller.ex
@@ -38,7 +38,7 @@ defmodule CocktailpartyWeb.Admin.ConnectionController do
 
         connection_types = ConnectionTypes.all()
 
-        render(conn, :new, changeset: new_changeset, connection_types: connection_types)
+        render(conn, :new, changeset: new_changeset, connection_types: connection_types, show_connection_types: true)
     end
   end
 
@@ -51,14 +51,15 @@ defmodule CocktailpartyWeb.Admin.ConnectionController do
     connection_map = Input.get_connection_map!(id)
 
     changeset =
-      Input.change_connection(connection_map)
+      Input.change_edit_connection(connection_map)
       |> Map.put(:data, Input.switch_config_repr!(connection_map))
 
     connection_types = ConnectionTypes.all()
 
     render(conn, :edit,
       connection: connection_map,
       changeset: changeset,
+      show_connection_types: false,
       connection_types: connection_types
     )
   end

diff --git a/lib/cocktailparty_web/controllers/admin/connection_html.ex b/lib/cocktailparty_web/controllers/admin/connection_html.ex
@@ -7,7 +7,8 @@ defmodule CocktailpartyWeb.Admin.ConnectionHTML do
   Renders a connection form.
   """
   attr :changeset, Ecto.Changeset, required: true
-  attr :connection_types, :list, required: true
+  attr :connection_types, :list, required: false
+  attr :show_connection_types, :boolean, required: true
   attr :action, :string, required: true
 
   def connection_form(assigns)

diff --git a/lib/cocktailparty_web/controllers/admin/connection_html/connection_form.html.heex b/lib/cocktailparty_web/controllers/admin/connection_html/connection_form.html.heex
@@ -3,7 +3,7 @@
     Oops, something went wrong! Please check the errors below.
   </.error>
   <.input field={f[:name]} type="text" label="Name" />
-  <.input
+  <.input :if={@show_connection_types}
     field={f[:type]}
     type="select"
     label="Type"

diff --git a/lib/cocktailparty_web/controllers/admin/connection_html/edit.html.heex b/lib/cocktailparty_web/controllers/admin/connection_html/edit.html.heex
@@ -3,6 +3,11 @@
   <:subtitle>Use this form to manage connection records in your database.</:subtitle>
 </.header>
 
-<.connection_form changeset={@changeset} action={~p"/admin/connections/#{@connection}"} connection_types={@connection_types} />
+<.connection_form
+  changeset={@changeset}
+  action={~p"/admin/connections/#{@connection}"}
+  connection_types={@connection_types}
+  show_connection_types={@show_connection_types}
+/>
 
 <.back navigate={~p"/admin/connections"}>Back to connections</.back>
diff --git a/lib/cocktailparty_web/controllers/admin/connection_html/new.html.heex b/lib/cocktailparty_web/controllers/admin/connection_html/new.html.heex
@@ -3,6 +3,6 @@
   <:subtitle>Use this form to manage connection records in your database.</:subtitle>
 </.header>
 
-<.connection_form changeset={@changeset} action={~p"/admin/connections"} connection_types={@connection_types} />
+<.connection_form changeset={@changeset} action={~p"/admin/connections"} connection_types={@connection_types} show_connection_types={@show_connection_types}/>
 
 <.back navigate={~p"/admin/connections"}>Back to connections</.back>