fix(girest): Allow generation of generic endpoints for structs without methods#57
Open
sanchezcarballlido wants to merge 1 commit into
Open
fix(girest): Allow generation of generic endpoints for structs without methods#57sanchezcarballlido wants to merge 1 commit into
sanchezcarballlido wants to merge 1 commit into
Conversation
… methods Previously, '_generate_struct' returned early if 'n_methods == 0'. This prevented the generation of generic 'new' and 'free' endpoints for structs like 'GLib.SList' or 'GLib.List' that may not have exposed methods in certain environments. Removing the early return ensures these lifecycle endpoints are always created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where API endpoints for certain structs (specifically containers like
GLib.SListandGLib.List) were missing from the generated schema in some environments.The Problem
In
girest/main.py, the_generate_structfunction included an optimization checkif n_methods == 0: return. This caused the generator to abort processing immediately if a struct had no introspectable methods, skipping the logic to generate generic constructors (new) and destructors (free) that exists later in the function.The Fix
Removed the early return check. The generator now proceeds to evaluate if generic lifecycle endpoints are needed, regardless of the method count.
Verification
GLib.SListandGLib.Listare now correctly generated.