Conversation
Split WebSocket management into a separate useWebSocket hook that can be shared across multiple components (useCallbackRegistry, useBusRegistry, etc.). This refactoring: - Extracts WebSocket singleton logic into useWebSocket.ts - Simplifies useCallbackRegistry.ts to focus on callback execution - Maintains proper TypeScript types and linter compliance - Enables multiple hooks to share the same WebSocket connection per session - Fixes require() usage in connection-manager.ts to use proper ES6 imports
Change pass_filenames from false to true so that eslint only checks the files being committed, not all files in the workspace. This prevents pre-commit failures due to linter errors in unstaged files.
This new approach will reduce the latency on the app server communication. Include aiohttp now so we can call the callback in async mode
This will reduce the latency in the communication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.