-
Notifications
You must be signed in to change notification settings - Fork 542
storage: Add descriptions for DLQ parameters #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hiroshi Hatake <[email protected]>
WalkthroughDocumentation update to the storage configuration section, adding two new public configuration keys ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
administration/buffering-and-storage.md (1)
151-151: Minor formatting inconsistency instorage.keep.rejectedtable entry.There's a missing space before the closing pipe in the default value cell:
|Off|should be|Off|to align with adjacent rows (e.g., line 150).Apply this diff to fix the spacing:
-| `storage.keep.rejected` | When enabled, the dead-letter queue feature stores failed chunks that can't be delivered. Accepted values: `Off`, `On`. | `Off`| +| `storage.keep.rejected` | When enabled, the dead-letter queue feature stores failed chunks that can't be delivered. Accepted values: `Off`, `On`. | `Off` |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
administration/buffering-and-storage.md(1 hunks)
🔇 Additional comments (2)
administration/buffering-and-storage.md (2)
150-150: Typographical fix forstorage.delete_irrecoverable_chunkslooks good.The "Accepted values" format is now consistent with other entries in the table, using backticks around
OffandOn.
152-152: New DLQ path configuration entry is well-documented.The description clearly explains the relationship to
storage.pathand the runtime default behavior. The wording about the default subdirectory namerejectedbeing used "if not set" is helpful context for users.
esmerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 ship it
Corresponding PR is:
fluent/fluent-bit#11000
Summary by CodeRabbit