mp: fix flb_mp_accessor_keys_remove
for sibling keys removal
#10013
+143
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9091
The PR aims to make
flb_mp_accessor_keys_remove
work for sibling subkeys.The existing versions of the function can only remove one (the first) subkey of a given key. This method is used by several output plugins including
loki
which my team uses. We noticed that not all keys are removed from log records when there are multiple subkeys specified.A good example is provided in the added unit test, but here is another example of existing behaviour the PR is fixing.
Payload:
Accessor keys to remove:
Will result in only
pod_name
being removed. I.e.:With the PR change the output will be:
Valgrind output for unit tests
Valgrind output for main binary (with config)
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.