tests: fix tests that call pthread_join on stopped contexts and crash on macos. #10025
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad_join on an invalid tid. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
…read_join on an invalid tid. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
…lling pthread_join on an invalid tid. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
…esting an invalid mode. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
…ad_join on an invalid tid. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
pwhelan
requested review from
PettitWesley,
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
pthread_join(2)on an invalid or even NULLtidthe address sanitizer on macOS will raise an issue and crash fluent-bit. This has the effect on causing failures in CI.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.