-
Notifications
You must be signed in to change notification settings - Fork 179
Add support for MSK with IAM authentication #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reopening it based on conversation here. |
I fixed the dependencies that require Ruby > 3.0, so that the CI tests using Ruby 2.7 now also pass. I also added If there is interest at all in merging it in, I'd be happy to continue making improvements to the code with some input. Please let me know if this feature is not something that is considered useful and I can close the PR. In terms of possible improvements, I was wondering if it would be better to have a config param such as <match *>
@type rdkafka2
# other options
# AWS Region (required)
aws_msk_region us-east-1
# MSK IAM authentication settings (required)
rdkafka_options {
"security.protocol": "sasl_ssl",
"sasl.mechanisms": "OAUTHBEARER"
}
</match> the config could look like this: <match *>
@type rdkafka2
# ... other options ....
use_aws_msk_iam_auth true
aws_msk_region us-east-1
</match> Also, I was wondering if there is a way to not use the |
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
Any updates? |
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
Signed-off-by: Andrea Singh <[email protected]>
It helps to track new issues by aggregating ones from Project view. Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
/opt/hostedtoolcache/Ruby/3.4.2/x64/lib/ruby/gems/3.4.0/gems/ruby-kafka-1.5.0/lib/kafka/protocol/record_batch.rb:1: warning: bigdecimal was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add bigdecimal to your Gemfile or gemspec to silence this warning. Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: kuckjwi <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
27922c4
to
e23d33f
Compare
@daipom I have fixed the gemspec conflicts and signed off my commits. However, there is still a DCO issue that I don't know how to fix:
|
Closing this PR in favor of this one with a cleaner git history. |
Sorry for my late response. |
This adds support for using MSK IAM authentication with the
rdkafka2
output type. Authentication and authorization with an MSK cluster are facilitated through a base64-encoded signed URL, which is generated by the aws-msk-iam-sasl-signer-ruby library.