Track metadata in result maps #1002
Conversation
src/fluree/db/connection.cljc
Outdated
| @@ -16,7 +16,7 @@ | |||
| [fluree.db.nameservice :as nameservice] | |||
| [fluree.db.serde.json :refer [json-serde]] | |||
| [fluree.db.storage :as storage] | |||
| [fluree.db.track :as track] | |||
| [fluree.db.track :as track :refer [track?]] | |||
There was a problem hiding this comment.
Can we avoid using :refer? I heavily depend on project search to find usages when making changes, and while I can handle non-namespace-qualified function calls it slows me down a lot because I have to deal with many false positives.
I also think it's nice to have a visual call-out when I've got a dependency on another namespace.
I'm ok with referring macros, though, that's a small enough group that it's not hard to keep track of and because of widespread use the space efficiency of no namespace is more bang for the buck.
| :result result | ||
| :time (util/response-time-formatted start-time) | ||
| :fuel (fuel/tally fuel-tracker)} | ||
| :db staged-db |
There was a problem hiding this comment.
This looks like a breaking change, I don't know if nexus depends on this return value or not but we should give them a heads up - I do know they are heavy users of the :meta opt.
This patch begins to unify fuel, policy, and file metadata tracking under a track- api (more to come on that in subsequent prs). It also cleans up some of the
commit!process by removing theapply-stage!function which was made redundant by the new tracking apis. Now commits will contain any fuel, policy, or file metadata directly within the returned commit result if the tracking was turned on.