-
Notifications
You must be signed in to change notification settings - Fork 344
Add Queued Microtasks tab to VM Tools screen #9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3c3d89
to
d85106e
Compare
derekxu16
commented
Jun 3, 2025
d85106e
to
0f3ea7e
Compare
...ls_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_controller.dart
Outdated
Show resolved
Hide resolved
...ls_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_controller.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
...vtools_app/test/screens/performance/queued_microtasks/queued_microtasks_controller_test.dart
Outdated
Show resolved
Hide resolved
...vtools_app/test/screens/performance/queued_microtasks/queued_microtasks_controller_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/screens/performance/tabbed_performance_view_test.dart
Outdated
Show resolved
Hide resolved
bkonyi
reviewed
Jun 5, 2025
...ls_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_controller.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/screens/performance/tabbed_performance_view_test.dart
Outdated
Show resolved
Hide resolved
95e45ed
to
3a35a1d
Compare
I've added two separate commits: one for moving the feature to the VM Tools screen, and the other for addressing all other comments. |
3a35a1d
to
55a8ed3
Compare
kenzieschmoll
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with after final comments are addressed
...devtools_app/lib/src/screens/performance/panes/queued_microtasks/queued_microtasks_view.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Queued Microtasks tab to the VM Tools screen, which allows a user to see details about the microtasks scheduled in an isolate's microtask queue. This tab currently only appears when DevTools is connected to a Flutter or Dart app started with
--profile-microtasks
.