-
Couldn't load subscription status.
- Fork 3.4k
feat: migrate remaining logic from main.js #12587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the migration of client-side JavaScript logic from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the remaining JavaScript logic from main.js to Dart, enhancing the application's maintainability and performance. The changes include moving the getOS function, setting up platform-specific keys, and implementing table of contents functionality in Dart. The JavaScript file main.js is removed, and the corresponding script tag is removed from dash_layout.dart. The pull request also includes updates to the tab setup logic to use the Dart implementation of getOS.
|
Visit the preview URL for this PR (updated for commit 8e888f0): https://flutter-docs-prod--pr12587-feat-migrate-main-js-69tb2e8p.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo, goodbye & farewell JS 👋
Part of #12548
Migrate the remaining logic from main.js to Dart.