🐛 Make ThemeData properly wraps the content
#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that ThemeData is correctly applied around key widget content and standardizes build method signatures across camera picker components.
- Expose and forward a
KeyinpushToViewerto improve widget identifiability - Wrap viewer content in a
Themeand replace scatteredthemevariable usage withTheme.of(context) - Convert positional builder methods to named parameters and allow a nullable focus color
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/widgets/camera_picker_viewer.dart | Added an optional Key parameter to pushToViewer and forwarded it |
| lib/src/widgets/camera_picker.dart | Suppressed the deprecated indicatorColor warning |
| lib/src/widgets/camera_focus_point.dart | Made color nullable and conditionalized paint.color assignment |
| lib/src/states/camera_picker_viewer_state.dart | Wrapped preview material in a Theme/Builder, updated theme access |
| lib/src/states/camera_picker_state.dart | Refactored many buildXxx methods to named parameters and nested theming, plus added an AnnotatedRegion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also makes build widget methods' signatures consistent.