fix(battery_plus): Improve battery save mode check on Xiaomi devices #3555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement for #3537 as there were no reply and no access to allow editing by maintainers. Additionally, I have bumped the min Android version, because with having min Flutter version allowed as 3.22.0 in the pubspec we have Android 5 (API 21) and newer only supported anyway as mentioned in this article: https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3
Note, I don't have recent Xiaomi devices to validate the fix, so can't guarantee the result. However, the change seems similar to other manufacturers battery save mode check.
Related Issues
Closes #3540
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).