Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KEDA HTTPScaledObjects support #1748

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: correct typo in AutoscalerReference type name
- Fix spelling of AutoscalerReference (was AutoscalerRefernce) in type definition and struct field

Signed-off-by: kahirokunn <[email protected]>
kahirokunn committed Dec 17, 2024

Verified

This commit was signed with the committer’s verified signature.
kahirokunn kahirokunn
commit 43cba61b8624a0b290c9c8d72784cc754ecbc289
4 changes: 2 additions & 2 deletions pkg/apis/flagger/v1beta1/canary.go
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ type CanarySpec struct {

// AutoscalerRef references an autoscaling resource
// +optional
AutoscalerRef *AutoscalerRefernce `json:"autoscalerRef,omitempty"`
AutoscalerRef *AutoscalerReference `json:"autoscalerRef,omitempty"`

// Reference to NGINX ingress resource
// +optional
@@ -459,7 +459,7 @@ type LocalObjectReference struct {
Name string `json:"name"`
}

type AutoscalerRefernce struct {
type AutoscalerReference struct {
// API version of the scaler
// +required
APIVersion string `json:"apiVersion,omitempty"`
10 changes: 5 additions & 5 deletions pkg/apis/flagger/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/canary/deployment_fixture_test.go
Original file line number Diff line number Diff line change
@@ -396,7 +396,7 @@ func newDeploymentControllerTestCanary(cc canaryConfigs) *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",
2 changes: 1 addition & 1 deletion pkg/canary/scaled_object_reconciler_test.go
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@ func Test_setPrimaryScaledObjectQueries(t *testing.T) {
TargetRef: flaggerv1.LocalObjectReference{
Name: "podinfo",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
},
},
4 changes: 2 additions & 2 deletions pkg/controller/scheduler_deployment_fixture_test.go
Original file line number Diff line number Diff line change
@@ -296,7 +296,7 @@ func newDeploymentTestCanary() *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",
@@ -358,7 +358,7 @@ func newDeploymentTestCanaryAB() *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",