fix(invites): resolve the runtime configuration form on self hosted instances. - #1419
Open
notrevenant wants to merge 3 commits into
Open
fix(invites): resolve the runtime configuration form on self hosted instances.#1419notrevenant wants to merge 3 commits into
notrevenant wants to merge 3 commits into
Conversation
Author
|
I was not sure what to title this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Closes #1217
Summary
What changed:
Modified InviteRegisterPage.tsx to respect the instance's registration settings. When the instance is set to "invite-only" the page now shows the proper registration form instead of allowing open registration (display name).
Why it is correct:
Previously, the invite flow ignored the RuntimeConfig settings and always allowed registration. It only collected a display name, which wasn't sufficient for account creation if the instance was set to invite only. Now it uses the same registration flow as the index page.
Risk:
Low as it reuses existing, tested registration logic from other code (AuthMinimalRegisterFormore.tsx).
What I didn't do:
Verification
None
Used docker to custom build the frontend and ran a test on a "incognito" tab to clear the data to see whether the applied change works or not.
Checklist
LLM Disclosure
Used AI assistance (Claude) to navigate and study the monorepo and pinpoint where the problem occurs.