Skip to content

ci(framework): Add framework preparation hook#7034

Merged
danieljanes merged 4 commits intomainfrom
framework-prepare-hook
May 5, 2026
Merged

ci(framework): Add framework preparation hook#7034
danieljanes merged 4 commits intomainfrom
framework-prepare-hook

Conversation

@psfoley
Copy link
Copy Markdown
Member

@psfoley psfoley commented Apr 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 23:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a CI “framework preparation” hook so the framework test workflow can run a dedicated pre-install step (currently a no-op), providing an extension point for future synchronization/setup needs.

Changes:

  • Add framework/dev/prepare-framework.sh as a preparatory script (currently prints a skip message).
  • Invoke the new script from .github/workflows/framework-test.yml before dependency installation, gated behind the existing path-change conditions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
framework/dev/prepare-framework.sh Adds a new framework preparation hook script (currently no-op).
.github/workflows/framework-test.yml Runs the preparation hook step in the Framework Python CI workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/dev/prepare-framework.sh
@github-actions github-actions Bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Apr 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@psfoley psfoley marked this pull request as draft April 24, 2026 03:51
@psfoley psfoley marked this pull request as ready for review May 4, 2026 19:08
@danieljanes danieljanes enabled auto-merge (squash) May 5, 2026 18:00
@danieljanes danieljanes merged commit 854a25c into main May 5, 2026
128 of 129 checks passed
@danieljanes danieljanes deleted the framework-prepare-hook branch May 5, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants