refactor(framework): Make details and sub_status columns in Run table not nullable#7063
Merged
danieljanes merged 36 commits intomainfrom May 6, 2026
Merged
refactor(framework): Make details and sub_status columns in Run table not nullable#7063danieljanes merged 36 commits intomainfrom
details and sub_status columns in Run table not nullable#7063danieljanes merged 36 commits intomainfrom
Conversation
Co-authored-by: Heng Pan <[email protected]>
… failed and a helpful detail message; added test
github-actions
Bot
added
the
Maintainer
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LinkState run table schema so that sub_status and details are no longer nullable, aligning the schema definition, ER diagram documentation, and database migrations.
Changes:
- Make
run.sub_statusandrun.detailsNOT NULLwith an empty-string server default in SQLAlchemy schema metadata. - Update the schema ERD (
README.md) to reflectdetails/sub_statusas non-nullable. - Add an Alembic migration that backfills existing NULLs and enforces
NOT NULL+ server defaults.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| framework/py/flwr/supercore/state/schema/linkstate_tables.py | Marks run.sub_status/run.details as nullable=False with empty-string defaults |
| framework/py/flwr/supercore/state/schema/README.md | Updates ER diagram to show details/sub_status as non-nullable |
| framework/py/flwr/supercore/state/alembic/versions/rev_2026_04_30_make_run_substatus_and_details_not_nullable.py | Adds migration to backfill NULLs and enforce NOT NULL + defaults |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
danieljanes
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.