Improv : logic changes for selection cancellation #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug where large vertical or horizontal elements would get cancelled
apply corrections - move actions logic into `trash_selection` - small rename of canceled* to have coherent naming between variables and functions getters/settesr - move comment closer to the `canceled_state` variable (variable-level docstring) - constant added as such fmt and hashset
…hortcuts and pass to pens This adds a `temporary_tool` bool to the `PenHolder` which signifies whether the following sequence occured (for now only with the selector) 1. activates the selector 2. Select something then lift the pen (triggering an up or cancel event) 3. go back with the selector activated via a temporary shortcut 4. Select something else Then the temporary style will be `true` as going back will trigger again the `handle_pressed_shortcut_key` function on the pen down event.
|
I've added a commit to fix #888. This last commit needs some testing (and maybe some renaming) to be sure everything works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Fixes #888
A couple remarks :
shapes need an additional up/down cycle : we could change it to follow the same logic as the brush but this could also be done by not changing the logic of the shape part and only disallowing shapes to be too small (in that case we can create shapes that aren't even visible but are still part of the document)This does not change behavior when a selection is deleted.Rebase of the previous PR #1139 with the new clone! syntax