Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM folioci/alpine-jre-openjdk17:latest
FROM folioci/alpine-jre-openjdk21:latest

# Install latest patch versions of packages: https://pythonspeed.com/articles/security-updates-in-docker/
USER root
Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
buildMvn {
publishModDescriptor = true
mvnDeploy = true
buildNode = 'jenkins-agent-java17'
buildNode = 'jenkins-agent-java21'

doDocker = {
buildJavaDocker {
Expand Down
9 changes: 9 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 1.16.1 2025-09-25
* [MODNCIP-90](https://folio-org.atlassian.net/browse/MODNCIP-90) RequestItem service - make hrid optional (Sunflower)

## 1.16.0 2025-09-25
* Copy of 1.15.7 - version correction for Sunflower

## 1.15.7 2025-03-12
* [FOLREL-651](https://folio-org.atlassian.net/browse/FOLREL-651) Update to Java 21

## 1.15.6 2024-11-21
* Fix missing permission issue
* Use item call number from AcceptItem request if it is provided
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.folio</groupId>
<artifactId>mod-ncip</artifactId>
<version>1.15.7-SNAPSHOT</version>
<version>1.17.0-SNAPSHOT</version>
<name>NCIP</name>
<description>NCIP responder for FOLIO (internal module)</description>

Expand All @@ -18,7 +18,7 @@
<vertx.version>4.5.10</vertx.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>17</java.version>
<java.version>21</java.version>
<org.extensiblecatalog.ncip.v2.version>4.1.0</org.extensiblecatalog.ncip.v2.version>
</properties>

Expand Down
14 changes: 14 additions & 0 deletions src/main/java/org/folio/ncip/FolioRemoteServiceManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,20 @@ public JsonObject requestItem(RequestItemInitiationData initData) throws Excepti

String searchUrl = baseUrl + (titleRequest ? Constants.INSTANCE_SEARCH_URL : Constants.ITEM_SEARCH_URL)
.replace("$hrid$", hrid);

// This allows the place request service to work with only the barcode in the request. This is a fallback when hrid is missing.
if ((hrid == null || hrid.isEmpty()) && !titleRequest) {
if (initData != null && initData.getRequestId() != null) {
String barcode = initData.getRequestId().getRequestIdentifierValue();
if (barcode != null && !barcode.isEmpty()) {
searchUrl = baseUrl + (Constants.ITEM_SEARCH_BY_BARCODE_URL)
.replace("$barcode$", barcode);
logger.info("using barcode");
logger.info(searchUrl);
}
}
}

String responseString = callApiGet(searchUrl);
JsonObject response = new JsonObject(responseString);

Expand Down