Skip to content

UICIRCLOG-190: Add stripes-core.settings.read permission to app permissions.#271

Merged
Dmytro-Melnyshyn merged 3 commits intomasterfrom
UICIRCLOG-190
Feb 25, 2026
Merged

UICIRCLOG-190: Add stripes-core.settings.read permission to app permissions.#271
Dmytro-Melnyshyn merged 3 commits intomasterfrom
UICIRCLOG-190

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

Purpose

Use stripes-core's universal read-only permission set so users who only have access to this app have the necessary permissions to execute API queries during session init.

Refs

https://folio-org.atlassian.net/browse/UICIRCLOG-190

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team February 23, 2026 10:44
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Jest Unit Test Results

101 tests  ±0   101 ✅ ±0   1m 54s ⏱️ -10s
 15 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9af9f0e. ± Comparison against base commit 438d4fa.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit bea2d58 into master Feb 25, 2026
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UICIRCLOG-190 branch February 25, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants