Skip to content

Support complete_remote_package! #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Apr 10, 2025

Fix #3178

This also removes the assumption that REPLMode.complete_remote_package is defined, which caused the precomp failure

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pkg-complete_remote_package-1.11")
julia> using Pluto

@fonsp
Copy link
Owner Author

fonsp commented Apr 10, 2025

Julia 1.12 tests are failing because of #3175

But I don't think we can test this on CI yet, the 1.11 and 1.12 Pkg versions are not yet (pre)released.

@danielwe
Copy link
Contributor

With 1.11.5 now released, this is needed for precompilation to succeed and Pluto to work

@danielwe
Copy link
Contributor

danielwe commented Apr 14, 2025

I suppose it would also be good to submit a PR to the registry to cap the Julia compat of existing Pluto releases at 1.11.4? At least for every release since 0.15, which was the first that included #844

@PatrickHaecker
Copy link

I second to act quickly here. Currently, we violate the users assumption that stable updates are stable. Telling everyone to just do

(@v1.11) pkg> add Pluto#pkg-complete_remote_package-1.11

is possible, but not very user friendly and will hunt us in the future when they stay on this branch.

@fonsp fonsp merged commit e246cb6 into main Apr 15, 2025
4 of 14 checks passed
@fonsp fonsp deleted the pkg-complete_remote_package-1.11 branch April 15, 2025 07:06
@fonsp
Copy link
Owner Author

fonsp commented Apr 15, 2025

Required one more fix in 5619f89

releasing after CI

@PatrickHaecker
Copy link

Thanks a lot for doing a release so quickly today!

@fonsp
Copy link
Owner Author

fonsp commented Apr 15, 2025

Fixes #3191 and #3190

icweaver added a commit to icweaver/onaketa-org that referenced this pull request Apr 25, 2025
Workaround until fonsp/Pluto.jl#3180 upstreamed to PlutoSliderServer.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update needed for tweak in Pkg for new julia 1.11
3 participants