-
-
Notifications
You must be signed in to change notification settings - Fork 301
Support complete_remote_package! #3180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Julia 1.12 tests are failing because of #3175 But I don't think we can test this on CI yet, the 1.11 and 1.12 Pkg versions are not yet (pre)released. |
With 1.11.5 now released, this is needed for precompilation to succeed and Pluto to work |
I suppose it would also be good to submit a PR to the registry to cap the Julia compat of existing Pluto releases at 1.11.4? At least for every release since 0.15, which was the first that included #844 |
I second to act quickly here. Currently, we violate the users assumption that stable updates are stable. Telling everyone to just do (@v1.11) pkg> add Pluto#pkg-complete_remote_package-1.11 is possible, but not very user friendly and will hunt us in the future when they stay on this branch. |
Required one more fix in 5619f89 releasing after CI |
Thanks a lot for doing a release so quickly today! |
Workaround until fonsp/Pluto.jl#3180 upstreamed to PlutoSliderServer.jl
Fix #3178
This also removes the assumption that
REPLMode.complete_remote_package
is defined, which caused the precomp failureTry this Pull Request!
Open Julia and type: