Skip to content

feat: inject NODE_IP env var in all containers #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: inject NODE_IP env var in all containers #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions internal/resources/applications/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,30 @@ func (a Application) withJsonLogging(ctx core.Context) core.ObjectMutator[*appsv
}
}

func (a Application) withNodeIP(ctx core.Context) core.ObjectMutator[*appsv1.Deployment] {
return func(deployment *appsv1.Deployment) error {
nodeIPEnvVar := corev1.EnvVar{
Name: "NODE_IP",
ValueFrom: &corev1.EnvVarSource{
FieldRef: &corev1.ObjectFieldSelector{
FieldPath: "status.hostIP",
},
},
}

for i, container := range deployment.Spec.Template.Spec.InitContainers {
container.Env = append(container.Env, nodeIPEnvVar)
deployment.Spec.Template.Spec.InitContainers[i] = container
}
for i, container := range deployment.Spec.Template.Spec.Containers {
container.Env = append(container.Env, nodeIPEnvVar)
deployment.Spec.Template.Spec.Containers[i] = container
}

return nil
}
}

func (a Application) handleDeployment(ctx core.Context, deploymentLabels map[string]string) error {
condition := v1beta1.Condition{
Type: "DeploymentReady",
Expand All @@ -358,6 +382,7 @@ func (a Application) handleDeployment(ctx core.Context, deploymentLabels map[str
a.withStatefulHandling(ctx),
a.withEELicence(ctx),
a.withJsonLogging(ctx),
a.withNodeIP(ctx),
core.WithController[*appsv1.Deployment](ctx.GetScheme(), a.owner),
)

Expand Down