Skip to content

Fix encoding for non-ascii char in kerberos authentication #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix encoding for non-ascii char in kerberos authentication #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impacket/krb5/asn1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class KerberosString(char.GeneralString):
# TODO marc: I'm not sure how to express this constraint in the API.
# For now, we will be liberal in what we accept.
# subtypeSpec = constraint.PermittedAlphabetConstraint(char.IA5String())
pass
encoding = 'utf-8'

class Realm(KerberosString):
pass
Expand Down
4 changes: 2 additions & 2 deletions impacket/krb5/kerberosv5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def getKerberosTGT(clientName, password, domain, lmhash, nthash, aesKey='', kdcH
except PyAsn1Error:
salt = ''

encryptionTypesData[etype2['etype']] = b(salt)
encryptionTypesData[etype2['etype']] = salt.encode('utf-8')
elif method['padata-type'] == constants.PreAuthenticationDataTypes.PA_ETYPE_INFO.value:
etypes = decoder.decode(method['padata-value'], asn1Spec = ETYPE_INFO())[0]
for etype in etypes:
Expand All @@ -245,7 +245,7 @@ def getKerberosTGT(clientName, password, domain, lmhash, nthash, aesKey='', kdcH
except PyAsn1Error:
salt = ''

encryptionTypesData[etype['etype']] = b(salt)
encryptionTypesData[etype['etype']] = salt.encode('utf-8')

enctype = supportedCiphers[0]

Expand Down