-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove drawerEdgeDragWidth property #674
base: main
Are you sure you want to change the base?
fix: remove drawerEdgeDragWidth property #674
Conversation
it doesn't fix the issue.. Check again.. |
Thanks for letting me know about this, i found why this doesn't work with Android. When displaying a single line of code in the Swapped the controllers so that the parent scrolls horizontally and the child scrolls vertically. This ensures that horizontal scrolling is always possible, even when dragging in the empty space below a single-line code block. |
Before diving deeper into this issue, I think it’s best to wait for a mentor to review the bug/behavior. Also, if you’re making changes, please ensure they are properly tested first. |
This solution resolves scrolling problems on Mobile (I verified on Android). However in desktop it negatively impacts the accessibility by hiding the vertical scrollbar to the right and not showing the horizontal scrollbar. code-pane-scroll-issue.mp4 |
Set the draweredgewidth to zero(everything works well).. it currently covers the whole width of screen.. we can give half or one third of contextwidth to drawer .. or an Alternative solution is expected ? |
@badnikhil I've added my comments in the issue thread. |
PR Description
The issue occurred because
drawerEdgeDragWidth
was set tocontext.width
(entire screen width), causing the entire screen width to act as the drawer drag area. This prevented horizontal scrolling from working properly.Fix: Removed drawerEdgeDragWidth: context.width, which restored the expected horizontal scroll behavior while keeping the drawer functional.
Related Issues
Checklist
main
branch before making this PRflutter upgrade
and verify)flutter test
) and all tests are passingAdded/updated tests?
OS on which you have developed and tested the feature?