Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed swift Code (Tested) #693

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

badnikhil
Copy link
Contributor

@badnikhil badnikhil commented Mar 23, 2025

PR Description

The swift code is fixed ,tests are updated and response is verified from other languages' codes.
Everything explained in the issue are fixed
Used Semaphore to wait for the async response and stop when response is recieved .It also prevent premature exits.

Tested with

swift-driver version: 1.115.1 Apple Swift version 6.0.3 (swiftlang-6.0.3.1.10 clang-1600.0.30.1)
Target: arm64-apple-macosx15.0

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run related tests and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • [] No,

OS on which you have developed and tested the feature?

  • macOS (MacBook Air M1)

@badnikhil badnikhil marked this pull request as ready for review March 23, 2025 00:24
@ashitaprasad
Copy link
Member

ashitaprasad commented Mar 23, 2025

This was not expected from you @badnikhil - Why did it not occur to you that you modified the codegen template still no test was failing?
It was because the tests were skipped as they required manual verification.
Each and every generated output code has to be manually executed on the local system to ensure that the generated code runs for every test case.

@badnikhil
Copy link
Contributor Author

badnikhil commented Mar 23, 2025

This was not expected from you @badnikhil - Why did it not occur to you that you modified the codegen template still no test was failing? It was because the tests were skipped as they required manual verification. Each and every generated output code has to be manually executed on the local system to ensure that the generated code runs for every test case.

I am sorry for the haste. Actually I made this PR in hurry I will verify everything again.
I found the issue when I was working on pr #681 .. and I was planning to update tests cases in that so I was a bit confused

@badnikhil badnikhil marked this pull request as draft March 23, 2025 17:11
@badnikhil
Copy link
Contributor Author

@ashitaprasad drafted this PR for now.. I will open this after working with tests.

@badnikhil badnikhil marked this pull request as ready for review March 28, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong Swift Codegen (httpSession)
2 participants