Skip to content

fix: multiple line input and alignment of apply coupons in text box #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2020
Merged

fix: multiple line input and alignment of apply coupons in text box #2698

merged 8 commits into from
May 10, 2020

Conversation

@Dhruv-194
Copy link
Contributor

@Dhruv-194 Dhruv-194 commented May 8, 2020 •
edited
Loading

Fixes #2621

Multi line input and alignment of apply coupons.

The bug was -
The alignment of the apply coupons Edit text is not proper also there is multi line input for it.

Now after fixing -
I fixed the 'Apply Discount Coupon' EditText in "fragment_tickets.xml" file where now only single line input will be allowed. Further I aligned the EditText with 'Apply' Button.

Changes: The changes were put into the "fragment_tickets.xml" file.

Screenshot-
Screenshot_20200510-031234

@Dhruv-194 Dhruv-194 changed the title Fixed issue #2621 - multi line input and alignment of apply coupons … Fixed issue: multi line input and alignment of apply coupons … May 8, 2020
@iamareebjamal
Copy link
Member

No need to list changes in PR, we can see them in proper diff. Please add screenshots of the change instead. Also, your PR title is not following project conventions. Please see titles of merged PRs

@iamareebjamal
Copy link
Member

Also, your PR doesn't link the fixed issue correctly. Please see merged PRs

@Dhruv-194 Dhruv-194 changed the title Fixed issue: multi line input and alignment of apply coupons … Fixed issue: multi line input and alignment of apply coupons May 8, 2020
@Dhruv-194
Copy link
Contributor Author

No need to list changes in PR, we can see them in proper diff. Please add screenshots of the change instead. Also, your PR title is not following project conventions. Please see titles of merged PRs

I have changed the title but still it is not considering it. Moreover as I am new and this is my first contribution ever, can you please tell me how to link this PR properly? I have looked into many merged PR but I am unable to find out what I am missing.

@iamareebjamal
Copy link
Member

Look what's the pattern of titles in merged PRs and how the issue is linked. You need to look exactly. See other open PRs how they are writing the title for bug fixes and linking issues

@iamareebjamal
Copy link
Member

Literally any open bug fix will do

#2636
#2637
#2349
#2617
#2587

@Dhruv-194
Copy link
Contributor Author

Literally any open bug fix will do

#2636
#2637
#2349
#2617
#2587

I tried merging the entire thing again with correct semantic of commit message and the PR title.
But still it is not considering. I don't know what to do now
If you know anything please tell otherwise I won't be able to contribute more than this.

@iamareebjamal
Copy link
Member

No merging of anything is required. You have to change the PR title to follow the pattern and link the issue in the PR message in the standard way github provides. I have already linked multiple PRs of new contributors who have done it as well. And you'll have to link issues in this way on any GitHub project, so doesn't matter if you learn it today or tomorrow, Open Source is not just about sending PRs, it's also about following project conventions and learning things by looking around

Neither your PR title follows the convention, nor you have linked the issue in the PR body like in other PRs. You have to do it exactly the way others have done

You are a programmer, and you should already understand the strict nature of languages and context-sensitive information. If the command to print a line is System.out.println("messages"), you can't write Print.the line (message), pretty please. So please, follow the conventions like other people have and link the issue exactly as others have, it has to be word to word, you can't add your choice of words in between just for fun, it has to be exact. And you have to follow the PR title convention, like other people have. If you can't see the difference between Fixed issue: multi line input and alignment of apply coupons and fix: added a scroll view in past ticket filter, I am sorry, I can't help you further.

I can change it myself in 2 seconds or tell you exactly what to do, but then you won't learn how to join and follow the conventions of any new community you contribute to. These are the things you'll eventually have to learn about any community

@Dhruv-194 Dhruv-194 changed the title Fixed issue: multi line input and alignment of apply coupons fix: multiple line input and alignment of apply coupons in text box May 8, 2020
@auto-label auto-label bot added the fix label May 8, 2020
@Dhruv-194
Copy link
Contributor Author

No merging of anything is required. You have to change the PR title to follow the pattern and link the issue in the PR message in the standard way github provides. I have already linked multiple PRs of new contributors who have done it as well. And you'll have to link issues in this way on any GitHub project, so doesn't matter if you learn it today or tomorrow, Open Source is not just about sending PRs, it's also about following project conventions and learning things by looking around

Neither your PR title follows the convention, nor you have linked the issue in the PR body like in other PRs. You have to do it exactly the way others have done

You are a programmer, and you should already understand the strict nature of languages and context-sensitive information. If the command to print a line is System.out.println("messages"), you can't write Print.the line (message), pretty please. So please, follow the conventions like other people have and link the issue exactly as others have, it has to be word to word, you can't add your choice of words in between just for fun, it has to be exact. And you have to follow the PR title convention, like other people have. If you can't see the difference between Fixed issue: multi line input and alignment of apply coupons and fix: added a scroll view in past ticket filter, I am sorry, I can't help you further.

I can change it myself in 2 seconds or tell you exactly what to do, but then you won't learn how to join and follow the conventions of any new community you contribute to. These are the things you'll eventually have to learn about any community

I have made the necessary changes by following the convention. Kindly please review it. Thanks!

@Dhruv-194
Copy link
Contributor Author

And also one more thing, the first commit was the right one and the last one has not changes.

@iamareebjamal
Copy link
Member

iamareebjamal commented May 9, 2020 •
edited by unfurl-links bot
Loading

There are no changes in the PR https://github.com/fossasia/open-event-attendee-android/pull/2698/files

GitHub
Fixes #2621 Multi line input and alignment of apply coupons. The bug was - The alignment of the apply coupons Edit text is not proper also there is multi line input for it. Now after fixing - I fix...

@Dhruv-194
Copy link
Contributor Author

Actually the first commit which I made had all the necessary changes after that I commited by mistake becuase I thought there was something wrong with my commit message. The last commit does not have any changes. So is there any way to revert back to the first commit where I have made all the changes?

@iamareebjamal
Copy link
Member

iamareebjamal commented May 9, 2020 •
edited by unfurl-links bot
Loading

https://git-scm.com/docs/git-reset

@Dhruv-194
Copy link
Contributor Author

Dhruv-194 commented May 9, 2020 •
edited by unfurl-links bot
Loading

There are no changes in the PR https://github.com/fossasia/open-event-attendee-android/pull/2698/files

GitHub**fix: multiple line input and alignment of apply coupons in text box by Dhruv-194 · Pull Request #2698 · fossasia/open-event-attendee-android**Fixes #2621
Multi line input and alignment of apply coupons.
The bug was -
The alignment of the apply coupons Edit text is not proper also there is multi line input for it.
Now after fixing -
I fix...

Sir Can you please check now

GitHub
Fixes #2621 Multi line input and alignment of apply coupons. The bug was - The alignment of the apply coupons Edit text is not proper also there is multi line input for it. Now after fixing - I fix...

iamareebjamal
iamareebjamal reviewed May 9, 2020
View reviewed changes
app/src/main/res/layout/fragment_tickets.xml Outdated
android:inputType="text"
android:maxLines="1"
android:layout_gravity="left"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty lines

iamareebjamal
iamareebjamal reviewed May 9, 2020
View reviewed changes
app/src/main/res/layout/fragment_tickets.xml Outdated
android:layout_height="wrap_content"

android:layout_gravity="right"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@iamareebjamal
Copy link
Member

No need to list changes in PR, we can see them in proper diff. Please add screenshots of the change instead.

@Dhruv-194
Update fragment_tickets.xml
bba108a 
Removed empty lines as per request
@iamareebjamal
Copy link
Member

#2698 (comment)

@Dhruv-194
Copy link
Contributor Author

#2698 (comment)

Done sir. Kindly review it now.

@iamareebjamal iamareebjamal merged commit 7cf1c1c into fossasia:development May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: multi line input and alignment of apply coupons

2 participants

@Dhruv-194 @iamareebjamal