Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for manufacturing device registration #199

Merged

Conversation

doanac
Copy link
Member

@doanac doanac commented Apr 6, 2021

Signed-off-by: Andy Doan [email protected]

@doanac doanac requested a review from MatthewCroughan April 6, 2021 03:36
@doanac
Copy link
Member Author

doanac commented Apr 6, 2021

@angolini - you may want to read this as well while you work through rolling out waves.

I fear this might be too terse and I've become too close to this problem to describe it adequately.

@doanac
Copy link
Member Author

doanac commented Apr 6, 2021

Fully detached
--------------
In this scenario devices connect to a reference server instance on
a private network. This network is isolated from the internet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear how CA cert will be uploaded to the backend if the network is isolated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first paragraph links to the device gateway PKI document - https://docs.foundries.io/80/reference-manual/security/device-gateway.html.

@mike-sul
Copy link
Contributor

mike-sul commented Apr 6, 2021

IMHO, this doc doesn't depict the key thing - PKI topology and how each element of it is generated/born starting from root CA private key. Without it, a customer is forced to do reverse engineering of the reference server and lmp-device-register in order to be able to produce its own manufacturing tooling or to understand all details.

@doanac
Copy link
Member Author

doanac commented Apr 6, 2021

@doanac
Copy link
Member Author

doanac commented Apr 6, 2021

Copy link
Contributor

@MatthewCroughan MatthewCroughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once commits have been squashed.

@doanac doanac force-pushed the factory-registration-ref branch from b3949ab to 2d8d0b6 Compare April 7, 2021 02:41
@doanac doanac force-pushed the factory-registration-ref branch from 2d8d0b6 to a0253ce Compare April 7, 2021 02:43
@doanac
Copy link
Member Author

doanac commented Apr 7, 2021

squashed and rebased on master

@doanac
Copy link
Member Author

doanac commented Apr 7, 2021

@MatthewCroughan MatthewCroughan merged commit 8abd961 into foundriesio:master Apr 7, 2021
@doanac doanac deleted the factory-registration-ref branch April 7, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants