Skip to content

Conversation

@caiotpereira
Copy link
Contributor

@caiotpereira caiotpereira commented Nov 14, 2025

The command cat ./deploy/images/intel-corei7-64/ostree_repo/refs/heads/ Returns the 64-characters SHA256 checksum required to use with fioctl targets add command.

The command find ./deploy/images/intel-corei7-64/ostree_repo -name *.commit provides the entire metadata + 64 characters SHA256.

When this value is used in the fioctl targets add command , it causes ERROR: Illegal base64 data at input byte 60.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

The command cat ./deploy/images/intel-corei7-64/ostree_repo/refs/heads/<refs>
Returns the 64-characters SHA256 checksum required to use with fioctl
targets add command.

The command find ./deploy/images/intel-corei7-64/ostree_repo -name
*.commit provides the entire metadata + 64 characters
SHA256.

When this value is used in the fioctl targets add command ,
it causes ERROR: Illegal base64 data at input byte 60.

Signed-off-by: Caio Pereira <[email protected]>
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when you're ready.

Copy link
Contributor

@mike-sul mike-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would probably extend the current "find" approach with info how to put together the commit hash. Something like:

path=$(find . -name "*.commit"); echo "$(basename $(dirname $path))$(basename $path | cut -d. -f1)"

and
add the new "cat" approach.

@caiotpereira
Copy link
Contributor Author

LGTM.

I would probably extend the current "find" approach with info how to put together the commit hash. Something like:

path=$(find . -name "*.commit"); echo "$(basename $(dirname $path))$(basename $path | cut -d. -f1)"

and add the new "cat" approach.

Thanks for the suggestion, but the cat approach is more straightforward.

@caiotpereira caiotpereira removed the request for review from doanac November 20, 2025 16:12
@caiotpereira caiotpereira self-assigned this Nov 20, 2025
@kprosise kprosise merged commit 692648b into foundriesio:main Nov 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants