-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lmp: facilitate changing the default user #1593
base: main
Are you sure you want to change the base?
Conversation
9ffe9b3
to
eee1302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's see what CS has to say
And @kprosise , please be aware that this will probably require change in the documentation
The default user created in LmP is 'fio' defined on the variable LMP_USER. Changing it also requires a static ID user tables change so it's easier if these tables with the default user can be easily rewritten. To simplify this process we will add the new tables just for the default user. files/lmp-passwd-table-default files/lmp-group-table-default To change the default user we need to change the LMP_USER and the new table files according to the desired new user name created. Signed-off-by: Jose Quaresma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, lgtm
@@ -144,8 +144,13 @@ ERROR_QA:remove = "version-going-backwards" | |||
# Required to avoid removing libraries used during signing | |||
RM_WORK_EXCLUDE += "make-mod-scripts" | |||
|
|||
# changing the default user also requires overriding the bellow files with the same user and group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# changing the default user also requires overriding the bellow files with the same user and group | |
# changing the default user also requires overriding the below files with the same user and group |
For the doc change, it may fit well here https://docs.foundries.io/latest/user-guide/lmp-customization/lmp-customization.html#lmp-users-and-groups |
The default user created in LmP is 'fio' defined on the variable LMP_USER. Changing it also requires a static ID user tables change so it's easier if these tables with the default user can be easily rewritten. To simplify this process we will add the new tables just for the default user.
files/lmp-passwd-table-default
files/lmp-group-table-default
To change the default user we need to change the LMP_USER and the new table files according to the desired new user name created.