Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: lmp: facilitate changing the default user #1593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quaresmajose
Copy link
Member

@quaresmajose quaresmajose commented Feb 21, 2025

The default user created in LmP is 'fio' defined on the variable LMP_USER. Changing it also requires a static ID user tables change so it's easier if these tables with the default user can be easily rewritten. To simplify this process we will add the new tables just for the default user.

files/lmp-passwd-table-default
files/lmp-group-table-default

To change the default user we need to change the LMP_USER and the new table files according to the desired new user name created.

@quaresmajose quaresmajose requested a review from a team February 21, 2025 16:21
@quaresmajose quaresmajose force-pushed the user branch 2 times, most recently from 9ffe9b3 to eee1302 Compare February 21, 2025 16:30
Copy link
Contributor

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see what CS has to say
And @kprosise , please be aware that this will probably require change in the documentation

The default user created in LmP is 'fio' defined on the
variable LMP_USER. Changing it also requires a static ID user tables
change so it's easier if these tables with the default user can
be easily rewritten. To simplify this process we will add the new
tables just for the default user.

 files/lmp-passwd-table-default
 files/lmp-group-table-default

To change the default user we need to change the LMP_USER and the
new table files according to the desired new user name created.

Signed-off-by: Jose Quaresma <[email protected]>
Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, lgtm

@@ -144,8 +144,13 @@ ERROR_QA:remove = "version-going-backwards"
# Required to avoid removing libraries used during signing
RM_WORK_EXCLUDE += "make-mod-scripts"

# changing the default user also requires overriding the bellow files with the same user and group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# changing the default user also requires overriding the bellow files with the same user and group
# changing the default user also requires overriding the below files with the same user and group

@vanmaegima
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants