chore(forge): avoid process::exit in results #11951
Open
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The TestOutcome::ensure_ok method calls std::process::exit(1), which makes the library code difficult to reuse (impossible to intercept/handle on the caller's side).
Solution
Replaced both calls to std::process::exit(1) in ensure_ok with a return to Err(...). This matches the method signature and the general error model in the project.
To avoid “breaking” quiet modes (JUnit/JSON) with an additional error string, I corrected the high-level error printing in crates/forge/bin/main.rs. Now sh_err!(“{err:?}”) is definitely printed there before process::exit(1). It is enough to wrap the print with a condition: do not print if shell::is_quiet() or shell::is_json(), but only set the exit code to 1.
PR Checklist